Repository navigation
Declare each conformance class as its standard publishes it - #89
Merged
Merged
Conversation
OGC API - Common - Part 2 (OGC 20-024) and the Coverages draft (OGC 19-087 1.0.0rc4) publish their class identifiers under https:// in their text, while their OpenAPI documents and OGC's Coverages test suite, ets-ogcapi-coverages10, write them under http://, the scheme OGC's naming policy (OGC 10-103r1) roots specification elements at. The suite compares identifiers as strings, so the https:// Coverages core alone fails its conformance test, and the http:// Common Part 2 collections alone is a string Part 2 never writes. The declaration names each class as its standard publishes it, and a class published under https:// also under http://. The EDR comment states the classes of EDR 1.1 the tier answers in part and does not declare.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Row A7 of the MobilityAPI plan (MobilityDB/MobilityDB#3805): each declared class named as its standard publishes it.
The defect
Two standards MobilityAPI declares publish their class identifiers under
https://in their text: OGC API - Common - Part 2 (OGC 20-024, clause 2 and its abstract tests) and the Coverages draft (OGC 19-087 1.0.0rc4, 132 identifiers, none underhttp://). Their OpenAPI documents write the same classes underhttp://, the scheme OGC's naming policy (OGC 10-103r1) roots specification elements at, and so does OGC's Coverages test suite:ets-ogcapi-coverages10checkshttp://www.opengis.net/spec/ogcapi-coverages-1/1.0/conf/coreby string equality (ConformanceClass.byConformanceClass).On master the declaration names the Coverages classes under
https://alone, so that suite's conformance test fails, and Common Part 2's collections underhttp://alone, a string Part 2's text never writes.The change
conformsTonames each class as its standard publishes it, and a class published underhttps://also underhttp://. Common Part 2's collections is written as Part 2 publishes it,https://, and the routes it marks carry that spelling.queries, eight queries each one a server MAY answer, of which the tier answers four;covjson, which names CoverageJSONapplication/prs.coverage+jsonwhere the tier writesapplication/vnd.cov+json, the type OGC CoverageJSON (OGC 21-069r2) defines.The test
TestConformanceNamesEachClassAsPublishedasserts the identifier the Coverages suite reads, the one the draft publishes, both spellings of Common Part 2's collections and Part 1's core underhttp://; that everyhttps://class has itshttp://spelling; and that a class published underhttp://alone gains nohttps://one. With thehttp://spelling removed fromconformsToit fails on seven identifiers.